[Workspace]Hide create workspace button for non dashboard admin #7357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7357 +/- ##
=======================================
Coverage 67.70% 67.70%
=======================================
Files 3520 3520
Lines 69700 69704 +4
Branches 11376 11378 +2
=======================================
+ Hits 47189 47193 +4
Misses 19716 19716
Partials 2795 2795
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
virajsanghvi
approved these changes
Jul 22, 2024
ruanyl
approved these changes
Jul 22, 2024
|
The failed cypress test is unrelated, merging now. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7357-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c1dd5c109f01faec151990a8864fcee80d218699
# Push it to GitHub
git push --set-upstream origin backport/backport-7357-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
wanglam
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Jul 23, 2024
…search-project#7357) * Hide create workspace for non dashboard admin Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR opensearch-project#7357 created/updated * Add more cases and update snapshot Signed-off-by: Lin Wang <[email protected]> * Update match rule Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
7 tasks
ruanyl
pushed a commit
that referenced
this pull request
Jul 23, 2024
… (#7382) * Hide create workspace for non dashboard admin * Changeset file for PR #7357 created/updated * Add more cases and update snapshot * Update match rule --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
… (#7382) * Hide create workspace for non dashboard admin * Changeset file for PR #7357 created/updated * Add more cases and update snapshot * Update match rule --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1f5f461) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Jul 23, 2024
… (#7382) (#7390) * Hide create workspace for non dashboard admin * Changeset file for PR #7357 created/updated * Add more cases and update snapshot * Update match rule --------- (cherry picked from commit 1f5f461) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only dashboard admin can create workspace, this PR hide create workspace entry in workspace menu and workspace list.
Issues Resolved
#7358
Screenshot
Workspace Menu
Workspace list
Testing the changes
yarn osd bootstrapconfig/opensearch_dashboards.ymlyarn start --no-base-pathopensearchDashboards.dashboardAdmin.usersinconfig/opensearch_dashboards.ymlChangelog
Check List
yarn test:jestyarn test:jest_integration